Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix highlighting in sidenav #211

Closed
psvenk opened this issue Dec 16, 2020 · 2 comments · Fixed by #225
Closed

Fix highlighting in sidenav #211

psvenk opened this issue Dec 16, 2020 · 2 comments · Fixed by #225
Labels
bug Something isn't working frontend Suspected problem with frontend (client-side code in public directory)
Milestone
2.6.2

Comments

@psvenk
Copy link
Member

psvenk commented Dec 16, 2020

There is no visual indication of the currently selected tab in the sidenav as there is when the sidenav is not open.
@psvenk psvenk added this to the 2.6.1 milestone Dec 16, 2020
@psvenk psvenk added bug Something isn't working frontend Suspected problem with frontend (client-side code in public directory) labels Dec 17, 2020
@notrodes
Copy link
Collaborator

also, the transition of the nav is soooo slooooooowwww moybe 0.2 sec is more appropriate, also also the css uses classes for everything not ids.

@jadebuckwalter jadebuckwalter linked a pull request Dec 23, 2020 that will close this issue
Fix sidenav highlighting #225
Merged
@jadebuckwalter
Copy link
Collaborator

@notrodes 0.2 sec is a little fast; 0.3 sec is better though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working frontend Suspected problem with frontend (client-side code in public directory)
Projects
None yet
Milestone
2.6.2
Development

Successfully merging a pull request may close this issue.

Fix sidenav highlighting jadebuckwalter/aspine
3 participants
@psvenk @notrodes @jadebuckwalter