Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sidenav highlighting #225

Merged
merged 4 commits into from
Dec 26, 2020
Merged

Fix sidenav highlighting #225

merged 4 commits into from
Dec 26, 2020

Conversation

jadebuckwalter
Copy link
Collaborator

Indicate which tab is currently open by changing the shade of that tab
in the sidenav.

@jadebuckwalter jadebuckwalter linked an issue Dec 23, 2020 that may be closed by this pull request
Fix highlighting in sidenav #211
Closed
@jadebuckwalter jadebuckwalter requested review from andOrlando, notrodes and psvenk and removed request for psvenk, notrodes and andOrlando December 23, 2020 19:19
@jadebuckwalter
Copy link
Collaborator Author

jadebuckwalter commented Dec 23, 2020 •
edited
Loading

  • Change highlighting in the sidenav so that it matches highlighting in the navbar
  • Fix the color scheme in the sidenav so that it matches the rest of Aspine
  • Change the background color of a selected tab to a darker grey (or lighter in dark mode)
  • Make sidenav an id instead of a class

jadebuckwalter and others added 4 commits December 26, 2020 10:08
@jadebuckwalter @psvenk
Fix sidenav highlighting
a55ecf1 
Indicate which tab is currently open by changing the shade of that tab
in the sidenav.
@jadebuckwalter @psvenk
Sidenav transition
e101c86 
Change sidenav transition from 0.5 seconds to 0.3 seconds.
@jadebuckwalter @psvenk
Fix colors in sidenav
c2f15ad 
Match the sidenav color scheme to the colors used in the navbar.

Change highlighting so that tabs turn a darker grey when hovered over
and an even darker grey when selected.

Make the dropdown menus take on a darker color when expanded (in order
to distinguish them from other buttons).

Co-authored-by: psvenk <45520974+psvenk@users.noreply.github.com>
@jadebuckwalter @psvenk
Change sidenav class to id
e52c9c3 
Remove .sidenav and replace it with #sidenav
psvenk
psvenk approved these changes Dec 26, 2020
View reviewed changes
Copy link
Member

@psvenk psvenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@psvenk psvenk added this to the 2.7.0 milestone Dec 26, 2020
@jadebuckwalter jadebuckwalter merged commit 1b97546 into Aspine:master Dec 26, 2020
@jadebuckwalter jadebuckwalter deleted the sidenav-highlight branch December 26, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psvenk psvenk psvenk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.2
Development

Successfully merging this pull request may close these issues.

Fix highlighting in sidenav
2 participants
@jadebuckwalter @psvenk