Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the service worker to install an extended cache of resources.… #115

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Conversation

notrodes
Copy link
Collaborator

… And removed verbose code in app.js that just made scope more explicit. In all files I changed callbacks to use arrow functions, const declarations and strict equality checks.

… And removed verbose code in app.js that just made scope more explicit. In all files I changed callbacks to use arrow functions, const declarations and strict equality checks.
@notrodes
Copy link
Collaborator Author

I have checked this, for testing chrome is a great debug tool. Firefox does not show service worker info in its debug tools but chrome does.

@notrodes notrodes requested review from psvenk and Ruborcalor and removed request for psvenk March 28, 2020 18:47
@psvenk psvenk removed their request for review March 28, 2020 19:59
@notrodes
Copy link
Collaborator Author

notrodes commented Apr 2, 2020

hellooo

Copy link
Member

@Ruborcalor Ruborcalor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff thanks for taking care of this 👍

@psvenk
Copy link
Member

psvenk commented Apr 2, 2020

Great stuff thanks for taking care of this +1

@Ruborcalor Ready to merge?

@notrodes notrodes merged commit ae81147 into Aspine:master Apr 2, 2020
@Ruborcalor
Copy link
Member

Yes looks good to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants