Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding documentation #128

Merged
merged 5 commits into from
Nov 11, 2020
Merged

Adding documentation #128

merged 5 commits into from
Nov 11, 2020

Conversation

notrodes
Copy link
Collaborator

this is not ready for a merge, just let me know if this is a good idea!

@psvenk
Copy link
Member

psvenk commented Jun 30, 2020

This seems like a good idea. I would put the typedefs in a separate types.ts file, specified using regular TypeScript syntax (export type TableDataObject = { ... }), and have one import block like this:

/**
 * @typedef {import("./types").TableDataObject} TableDataObject
 */

@psvenk
Copy link
Member

psvenk commented Sep 28, 2020

TODO (when reviewing this for merge): remove merge from origin to feature branch so that history is cleaner

@psvenk psvenk mentioned this pull request Oct 26, 2020
@psvenk psvenk merged commit 1a6405d into Aspine:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants