Removed synthetic statistics #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psvenk
force-pushed
the
removed-synthetic-statistics
branch
from
eec6720 to
a355470
Compare
fixed how synthetic assignments show statistics.
psvenk
force-pushed
the
removed-synthetic-statistics
branch
from
a355470 to
32f7b40
Compare
|
@andOrlando Thank you for your contribution. I noticed that |
Instead of keeping a global variable to count the number of synthetic assignments (which does not scale across classes), add a "synthetic" attribute to synthetic assignments and check against that.
psvenk
force-pushed
the
removed-synthetic-statistics
branch
from
6116621 to
7fc940f
Compare
psvenk
approved these changes
Oct 31, 2020
andOrlando
added a commit
that referenced
this pull request
Dec 16, 2020
Stop synthetic assignments (assignments added by the user) from offering to show nonexistent statistics Co-authored-by: psvenk <45520974+psvenk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #148. Here's the pull request. I forgot to do this last time. The only thing I changed was removing the info button and it's click event from synthetic assignments.