requestAnimationFrame update for clock #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from setInterval, this doesn't do it every 1000, it just kinda goes. Apparently it's more dynamic or something but since it's an issue I did it.
once every 4 seconds but this can be changed by editing the refreshes_per_second constant
oops I forgot to remove the log statement
psvenk
force-pushed
the
request-animation-frame-clock
branch
from
8f09ff9 to
ef80a08
Compare
last_interval does not need to be a global variable, so it, along with the function redraw_clock_with_timestamp, has been moved into the function scope of schedulesCallback. Furthermore, refreshes_per_second was hard-coded (witha comment) and redundant calls to requestAnimationFrame and redraw_clock were removed.
psvenk
approved these changes
Oct 26, 2020
andOrlando
added a commit
that referenced
this pull request
Dec 16, 2020
Switches setInterval to requestAnimationFrame (closes #135).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #135
switches setInterval to requestAnimationFrame, change the constant to change the frames/second or remove the constant altogether if you feel like hardcoding it. Also if you feel like it's best you could fix redraw_clock so it works with requestAnimationFrame but you could also just keep it as separate functions which is what I suggest.