Modify Aspine header onclick behavior (version 2) #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of simply adding the "active" class to whichever element using which someone switched tabs, find the button corresponding to the tab and specifically highlight that button when a tab is selected.
psvenk
approved these changes
Nov 19, 2020
andOrlando
pushed a commit
that referenced
this pull request
Dec 16, 2020
When clicking on the "Aspine" header, open the "Grades" tab and not the "Clock" tab. Co-authored-by: psvenk <45520974+psvenk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of pull request #169. Fixes one of the issues that pull request had (see my comment there). When you click on the clock it opens clock, and when you click elsewhere in the header it opens grades. Would close #168.