Add informative tooltips #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psvenk
commented
Dec 14, 2020
There was a problem hiding this comment.
I cannot "request changes" because this is identified as my pull request (due to my splitting this from #157), but @andOrlando here are some suggestions.
adds hover spans to certain (mostly header) icons. Please fix my css if I messed something up, especially that whole .tabulator-col .tabulator-header thing.
updates header-icon and a couple other icon classes so that they're centered in their columns. This was my first commit without the handholding of github desktop :)
Fixed the click areas that I messed up last time Changes how the icons are centered, makes them actually be in the center of the header instead of just using left padding also adds a tooltip for the hide button also makes the plus button green (sorry psvenk for not doing as separate commit)
I attempt to set up the tooltips as soon as the parents have an actual width so I can calculate what the margin-left should be
- Delay before and after clicking along with slight transition for opacity - removes header tooltips from some icons - adds tooltips to table icons - standardizes icon sizes to make it easier to hover/click - makes GPAType function only change the text and not the whole html of an element - updates setup_tooltip_margins to not do margins unless the width of its parent isn't 0
We have formed a consensus that 375ms is more discoverable than 750ms but still unobtrusive.
- fixes the said bug - reformats some of the toggle_fullscreen_pdf code for readability
Remove commented dead code and fix spacing of "for" loops
I was already using setup_tooltip_margins at various instances, so this just changes setup_tooltip_margins to encompass setting up the entire tooltip so that it's easier for more tooltips to be used in the future.
It was going too fast before, with barely any delay before it disappears so if someone were to hover over the tooltip right after they're on the icon it might fully or partially disappear before they get to it
Co-authored-by: psvenk <45520974+psvenk@users.noreply.github.com>
-changes a let to a const -instead of removing the class tooltip it removes the attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #178. This is split out from pull request #157, which became unwieldy due to mixing the info tab feature (which seems to be ready to merge) with the tooltips (which may need a few more changes). Please refer to that pull request for more details.