use a new library to parse command line args #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psvenk
requested changes
Dec 26, 2020
There was a problem hiding this comment.
Additional changes which I cannot put as inline comments (because GitHub won't let me comment on lines of code that were not changed):
npm install commanderand commitpackage.jsonandpackage-lock.json.minimistis no longer needed, so therequire('minimist')can be removed and we can alsonpm uninstall minimist.- The variables
privateKey,certificate, andcaare not needed and can be folded into the object literal forcredentials. - The version number should come dynamically from
package.json.
psvenk
reviewed
Dec 26, 2020
psvenk
reviewed
Dec 26, 2020
This is consistent with how the /version endpoint works and also differentiates between release and development versions.
psvenk
approved these changes
Dec 27, 2020
psvenk
added a commit
that referenced
this pull request
Jan 3, 2021
Following the changes to the CLI in pull request #233 ("use a new library to parse command line args"), bring back the start.sh script to minimize confusion.
psvenk
added a commit
that referenced
this pull request
Jan 5, 2021
Following the changes to the CLI in pull request #233 ("use a new library to parse command line args"), keep HTTPS enabled by default on production while disabling it by default on development, so that developers can simply run `npm start` instead of `npm start -- -i`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also some minor cleaning