Display New Version information from changelog at bottom of Info Page #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kdk1616
commented
Jan 5, 2021
kdk1616
commented
- Parses Markdown from CHANGELOG.md and displays at bottom of info page
tektaxi
approved these changes
Jan 5, 2021
psvenk
requested changes
Jan 5, 2021
|
Stop writing jquery!! |
|
Im fine not rewriting stuff, just stop writing morehow hard is that!?!?!? |
psvenk
requested changes
Jan 21, 2021
psvenk
requested changes
Jan 21, 2021
Changed header from 'Changelog' to 'What's New'
Co-authored-by: psvenk <45520974+psvenk@users.noreply.github.com>
Moved CSS to CSS file
Increased font size of "More Versions" link Removed paragraph at top of versions list with "Sematic Versioning" text
psvenk
approved these changes
Feb 1, 2021
There was a problem hiding this comment.
Looks good to me; I think this is ready to merge pending @notrodes' approval. I noticed that the changelog inclusion does not work in Aspine Lite, but I chose to split that into a separate issue (#250) (a) this is a sufficiently small feature, (b) the link to GitHub still exists on Aspine Lite, and (c) implementing this would require considerable work on the build script.
To improve performance, render the changelog when starting the server instead of doing it whenever the endpoint is reached.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.