Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some quality of life tooling #252

Merged
merged 4 commits into from
Feb 6, 2021
Merged

Added some quality of life tooling #252

merged 4 commits into from
Feb 6, 2021

Conversation

notrodes
Copy link
Collaborator

@notrodes notrodes commented Feb 2, 2021

Generate self signed certs for tests easily.

Copy link
Member

@psvenk psvenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some suggested style changes. However, this begs the question: is it really necessary to have SSL certificate tooling for development use? There is no real point in using HTTPS when connections are typically not even exposed to a LAN, much less the Internet.

serve.js Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
gen-key.sh Outdated Show resolved Hide resolved
@notrodes
Copy link
Collaborator Author

notrodes commented Feb 2, 2021

@psvenk I wanted to have this for when I work on the server.js and want to on https, wanted to allow others to do it easily as well.

@psvenk psvenk marked this pull request as draft February 2, 2021 19:31
Copy link
Member

@psvenk psvenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, but let's hold off on merging until 2.6.2 is put on production.

@notrodes notrodes marked this pull request as ready for review February 2, 2021 19:35
@psvenk psvenk modified the milestones: 2.7.0, 2.6.3 Feb 6, 2021
@psvenk psvenk merged commit 7ede2ad into Aspine:master Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants