Migrate schedule.json to TOML #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps readability and maintainability considerably. Some changes have been made to the frontend to work with native JavaScript Date objects instead of numbers.
|
Can you add an error throw as a default case in the switch statement on line 178 of clock.js? |
tektaxi
approved these changes
Apr 10, 2021
notrodes
reviewed
Apr 10, 2021
public/js/clock.js
Outdated
| for (const [, schedule] of Object.entries(schedules)) { | ||
| for (entry of schedule) { | ||
| // Convert each entry to a JavaScript Date object | ||
| let [, hours, minutes, seconds, ms] |
There was a problem hiding this comment.
Can you avoid this regex repeat?
Avoid repeating the regex for extracting components from a time, and make this part of the code more concise in general.
notrodes
approved these changes
Apr 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #253. This helps readability and maintainability considerably. Some changes have been made to the frontend to work with native JavaScript
Dateobjects instead of numbers.