Small edits to login.js #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 2, 2021 18:46
|
Also @notrodes re your comment: my reasoning for having the server send only an error code was that it plays nicely with the enum defined in the server code and that it allows us to change the verbiage without affecting the API in any way. I don't think the client-side performance hit is enough to merit SSR here (though it may be a good idea all things considered). |
notrodes
pushed a commit
to notrodes/aspine
that referenced
this pull request
Jul 24, 2021
Removed display hide because js does that now in switch. Removed a selector with commented out body. Changed documentation to jsdoc format. Small edits to login.js (Aspine#305) * Simplified the login.js file. Reduced logic to single switch. * Removed txt3 class because it does not exist, css used id reference. * Removed display hide because js does that now in switch. Removed a selector with commented out body.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this vein, either have server send full error text or server side render could be improvements.