Add support for fall 2021 schedule #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to using the fall 2021 schedule. Note that lunch is still in the A/B format and that lunch detection is not working.
Add lunch C and update get_lunch function
|
The lunch issue has (hopefully) been fixed, so this is ready for review (@tektaxi and/or anyone else). |
This is a temporary hack to correct for an issue on Aspen where period numbers on the schedule are reported incorrectly; namely, periods 2, 3, 4, PM are moved to the previous period (CM, 2, 3, 4). Refer to the description of pull request #311 for a screenshot illustrating the issue.
tektaxi
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #308 and adds support for the new schedule to
schedule.tomland the frontend generally. Lunch detection has not yet been updated for the new system.Additionally, there is a bug on Aspen which causes periods to be misaligned. We could compensate for this with some hacky code in our backend, but this will break once Aspen is fixed. So, I think the best course of action is to keep the backend code as-is and wait for Aspen to be fixed.
