Redesign tables on mobile #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hide and show columns in the Assignments and Categories tables based on the screen size.
The category of an assignment is hidden in the table on small screen sizes; include this information in the assignment info modal.
The load event listener creates a race condition which results in the assignments table header not loading properly on mobile. Instead, call adjustColumns just after the assignments and categories tables are populated with data. Additionally, this commit has adjustColumns take in as a parameter the table on which it operates, enabling the resize event listener to be initialized only once the tables are built. This prevents edge case race conditions and makes the code more generalizable (if we want to use adjustColumns for, e.g., the schedule table in the future).
Instead of occupying the entire screen, have the stats modal sit between the categories table and the assignments table.
|
I just now made a commit that moves the stats modal to be between the categories and assignments tables, but the styling could use some work. We should also look into giving the other modals the same treatment. |
Style the (no-longer) modal so that it looks more like the surrounding tables, remove extra padding, and remove animations. We still need to have the modal close when a different class is selected.
Close the stats modal when a different class is selected or the data is reset.
Treat the corrections modal as a stats modal, and have it appear above the stats modal and behave in the same way.
psvenk
requested changes
Mar 13, 2022
psvenk
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide and show columns in the Assignments and Categories tables based on
the screen size. Fixes #203.