Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login links #345

Merged
merged 4 commits into from
Oct 17, 2022
Merged

login links #345

merged 4 commits into from
Oct 17, 2022

Conversation

jshaw-7
Copy link
Collaborator

@jshaw-7 jshaw-7 commented Oct 13, 2022

Fixed old links and their formatting on the Login page

@jshaw-7 jshaw-7 requested a review from tektaxi October 13, 2022 16:23
Copy link
Collaborator

@tektaxi tektaxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! I think we could reduce the space between the district logo and the line with all the links, it feels like there's a lot of emptiness. Also not sure about the Instagram link...

@PoobyMalom PoobyMalom self-requested a review October 14, 2022 14:55
Copy link
Collaborator

@PoobyMalom PoobyMalom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@jshaw-7 jshaw-7 closed this Oct 17, 2022
@jshaw-7 jshaw-7 reopened this Oct 17, 2022
@jshaw-7 jshaw-7 changed the title Loginlinks Login Links Oct 17, 2022
@jshaw-7 jshaw-7 changed the title Login Links login links Oct 17, 2022
@tektaxi tektaxi self-requested a review October 17, 2022 16:15
Copy link
Collaborator

@tektaxi tektaxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! great work @jshaw-7 🎉

@jshaw-7 jshaw-7 merged commit 55ec532 into master Oct 17, 2022
@jshaw-7 jshaw-7 deleted the loginlinks branch October 17, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants