Fix bulleted list formatting and clarify license #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GNU has multiple licenses, so "GNU License" is ambiguous. I changed it to "GNU GPLv3" because that is the license in the file LICENSE.md, but I would recommend changing it to "GNU GPLv3 or later" (or even better, "GNU GPLv2 or later" if you want to be compatible with GPLv2), so that if a GPLv4 license is released, Aspine will be compatible with projects that use GPLv4. I have not made this change because I do not hold the copyright to the software and do not have the legal right to make such a decision about the license of the software.
|
I've closed this because there's another modification that I'd like to make before merging into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GNU has multiple licenses, so "GNU License" is ambiguous. I changed it to "the GNU General Public License, version 3" because that is the license in the file LICENSE.md, but I would recommend changing it to "the GNU General Public License, either version 3, or (at your discretion) any later version" (or even better, "the GNU General Public License, either version 2, or (at your discretion) any later version or later" if you want to be compatible with GPLv2), so that if a GPLv4 license is released, Aspine will be compatible with projects that use GPLv4. Note that "compatible" means that it is legally possible for two projects under different licenses to share code with each other (two-way compatibility in this specific context).
I have not made this change because I have not written a single line of code in Aspine and so do not hold the copyright to the software. If you want to change the wording of the license, you should be able to push directly to my fork because I checked the "Allow edits from maintainers" box.