Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabulator and Plotly improvements #43

Merged
merged 31 commits into from
Apr 9, 2019
Merged

Tabulator and Plotly improvements #43

merged 31 commits into from
Apr 9, 2019

Conversation

Ruborcalor
Copy link
Member

@Ruborcalor Ruborcalor commented Apr 4, 2019

Improvements such as:

  • Preventing unwanted scrolling on assignments table edit
  • Adding assignment filtering via the categories table
  • Redirecting to grades page when clicking on recent activity table

@Ruborcalor Ruborcalor changed the title Tabulator improvements Tabulator and Plotly improvements Apr 4, 2019
@Ruborcalor
Copy link
Member Author

Ruborcalor commented Apr 4, 2019

Improvements such as:

  • Boxplot rounding correction
  • Boxplot mean identification via line
  • Boxplot annotations for "Mean" and "Your Score"

@maxtkc
Copy link
Collaborator

maxtkc commented Apr 4, 2019

Looks great!

Two small possible additions for when an assignment is clicked in the recent activity table:

  • Select the Grades tab as if it was clicked
  • Select the class row corresponding to the clicked assignment

Also, a super quick fix:

  • When categories are selected, use the blue row select builtin to tabular (same as the classes table)

And styling stuff for Boxplot:

  • Make Your Score easier to see than Mean (swap colors of the two lines, make the text bigger/colored and in the same font as the page)

Feel free to nix any of these if you disagree.

Other than that, it looks ready to merge!

@Ruborcalor
Copy link
Member Author

Ruborcalor commented Apr 5, 2019

More Improvements:

  • Improve positioning of "Your Score" and "Mean" annotations so that their positions are dependent on screen width. This will ensure that they aren't cut off. (Or find way to not cut them off)
  • Add trace that divides plot into letter grades

@maxtkc maxtkc merged commit 82bab03 into master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants