-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add import/export functionality #62
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull in latest changes from upstream
The command-line options "json" and "out" have been introduced. If the "json" option is given, the json file at the given path is used instead of scraping Aspen. If the "out" option is given, Aspen is scraped as usual, but the data are dumped to a json file at the given path.
Command-line options are now allowed for "insecure" and "fake", i.e. `serve.js --insecure` and `serve.js --fake` are now valid (in addition to `serve.js insecure` and `serve.js fake`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR adds two command-line options,
json
andout
. Thejson
option allows the user to specify a JSON file to read from (instead of scraping Aspen), similar to running./serve.js fake
but with control over what file is used. Theout
option allows the user to specify a file to which JSON containing information about the user's grades, schedule, etc. is dumped. This JSON file can be read later by using thejson
option with Aspine'sserve.js
. Additionally, the argumentsinsecure
andfake
are now accepted both as arguments and as options (so./serve.js --insecure
is equivalent to./serve.js insecure
).Examples:
Use case: Aspen only allows students to see their current year and the previous year, thereby stopping students from viewing their grades from two years ago. This feature will make it much easier for students to archive their gradebook. Additionally, graduating students will be able to save their gradebook for future reference in case their accounts are terminated upon graduation.
Future additions: Some features that might be nice to implement down the road: