Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macOS install script and support multiple types of GPA (old) #92

Closed
wants to merge 17 commits into from

Conversation

kdk1616
Copy link
Collaborator

@kdk1616 kdk1616 commented Jan 12, 2020

Closes #83. Closes #71. Fixed mac install and start scripts (removed redis from start script)… Made function for toggling between weighted, unweighted, and % GPA (only works for current quarter right now... Also, There is a bug where if you select another quarter you cannot return to the initial quarter and have it work properly...).

kdk1616 and others added 2 commits January 12, 2020 17:09
…. Made function for toggling between weighted, unweighted, and % GPA (only works for current quarter right now... Also, There is a bu where if you select another quarter you cannot return to the initial quarter and have it work properly...).
Apparently kdk1616's editor completely changed the formatting of
the README. As there were no substantial changes, I have reverted
all changes that were made to the README.
@psvenk psvenk requested a review from Ruborcalor January 12, 2020 22:55
@psvenk psvenk changed the title Fixed mac install and start scripts (removed redis from start script)… Update macOS install script and support multiple types of GPA Jan 12, 2020
@psvenk
Copy link
Member

psvenk commented Jan 13, 2020

Looks good, but I found a few small issues, such as:

  • GPA indicator should be merged with GPA type selector, not with term dropdown
  • A GPA of 4.0, 3.0, etc. should be displayed with at least one place after the decimal point
  • The non-percent GPA formats do not play well with "Calculated GPA"

There is a function in extraFunctions.js to convert a percentage to
a GPA out of 4.0; the inline code duplicating that behavior has been
replaced by a function call.
This is a minor change, as the currently selected term is the same as
the current term when Aspine is first loading, but it aids code
readability for the refactoring to come.
Abstracting away the iterator reduces the potential for errors and
simplifies the code.
@psvenk psvenk self-requested a review January 14, 2020 00:12
@psvenk psvenk self-assigned this Jan 14, 2020
The GPA and calcGPA attributes of each term's object under tableData are
now themselves objects with attributes "percent", "outOfFour", and
"outOfFive". This approach is more scalable and also allows all GPAs
to be returned by a single function, computeGPA, which has been modified
to compute all three formats of GPA.
The current quarter need not be hardcoded anymore.
Also, the refactored GPAType uses jQuery and is more readable.
Because the selection of the <select> element is a string and it is
being compared to the number zero, I have changed triple equals
to double equals in order to invoke type coercion.
@psvenk
Copy link
Member

psvenk commented Jan 14, 2020

From what I've seen from editing the code the past two days, it seems that it may take around a week for this to be ready to merge.

@kdk1616 kdk1616 closed this Feb 15, 2020
@psvenk psvenk linked an issue Feb 19, 2020 that may be closed by this pull request
@psvenk psvenk removed a link to an issue Feb 19, 2020
@psvenk psvenk changed the title Update macOS install script and support multiple types of GPA Update macOS install script and support multiple types of GPA (old) Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise Mac install script Improved GPA calculator
2 participants