-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update macOS install script and support multiple types of GPA (old) #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Made function for toggling between weighted, unweighted, and % GPA (only works for current quarter right now... Also, There is a bu where if you select another quarter you cannot return to the initial quarter and have it work properly...).
Apparently kdk1616's editor completely changed the formatting of the README. As there were no substantial changes, I have reverted all changes that were made to the README.
psvenk
changed the title
Fixed mac install and start scripts (removed redis from start script)…
Update macOS install script and support multiple types of GPA
Jan 12, 2020
…riable for current term
Looks good, but I found a few small issues, such as:
|
There is a function in extraFunctions.js to convert a percentage to a GPA out of 4.0; the inline code duplicating that behavior has been replaced by a function call.
This is a minor change, as the currently selected term is the same as the current term when Aspine is first loading, but it aids code readability for the refactoring to come.
Abstracting away the iterator reduces the potential for errors and simplifies the code.
The GPA and calcGPA attributes of each term's object under tableData are now themselves objects with attributes "percent", "outOfFour", and "outOfFive". This approach is more scalable and also allows all GPAs to be returned by a single function, computeGPA, which has been modified to compute all three formats of GPA.
The current quarter need not be hardcoded anymore. Also, the refactored GPAType uses jQuery and is more readable.
Because the selection of the <select> element is a string and it is being compared to the number zero, I have changed triple equals to double equals in order to invoke type coercion.
From what I've seen from editing the code the past two days, it seems that it may take around a week for this to be ready to merge. |
psvenk
changed the title
Update macOS install script and support multiple types of GPA
Update macOS install script and support multiple types of GPA (old)
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #83. Closes #71. Fixed mac install and start scripts (removed redis from start script)… Made function for toggling between weighted, unweighted, and % GPA (only works for current quarter right now... Also, There is a bug where if you select another quarter you cannot return to the initial quarter and have it work properly...).