Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken browser builds #1398

Closed
dcodeIO opened this issue Jul 19, 2020 · 2 comments · Fixed by #1405
Closed

Broken browser builds #1398

dcodeIO opened this issue Jul 19, 2020 · 2 comments · Fixed by #1405

Comments

@dcodeIO
Copy link
Member

dcodeIO commented Jul 19, 2020

As mentioned in #1238 (comment), there is a strange problem with path.relative as used in asc since merging asconfig.

In particular

path.relative(".", "module.ts");

returns odule.ts in browser builds, but for some reason the following

const path = require("path-browserify");
path.relative(".", "module.ts");

returns module.ts as expected. What's known so far:

  • webpack bundles path-browserify v0.0.1
  • newest version is v1.0.1
  • Problem seems to happen here:
    exports.relative = function(from, to) {
      from = exports.resolve(from).substr(1);
      to = exports.resolve(to).substr(1); // <---
  • ?!

In general there appears to be another aspect to this since it's not easily reproducible outside of bundles. If you have any clue, please enlighten me :)

@dcodeIO dcodeIO added the bug label Jul 19, 2020
@dcodeIO
Copy link
Member Author

dcodeIO commented Jul 19, 2020

Related: browserify/path-browserify#21

@github-actions
Copy link

🎉 This issue has been resolved in version 0.14.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant