fix semicolon after interface + improve import object definition #1175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcodeIO
reviewed
Mar 16, 2020
dcodeIO
reviewed
Mar 16, 2020
MaxGraey
changed the title
dcodeIO
reviewed
Mar 16, 2020
jtenner
reviewed
Mar 16, 2020
|
Thank you so much @MaxGraey ! |
dcodeIO
reviewed
Mar 16, 2020
| ): Promise<ResultObject & { exports: ASUtil & T }>; | ||
|
|
||
| /** Synchronously instantiates an AssemblyScript module from a WebAssembly.Module or binary buffer. */ | ||
| export declare function instantiateSync<T extends {}>( | ||
| source: WebAssembly.Module | BufferSource, | ||
| imports?: ImportsObject | ||
| imports?: Imports | ||
| ): ResultObject & { exports: ASUtil & T }; |
There was a problem hiding this comment.
Not directly related to this PR, but according to MDN there's also a slight variance here: If a WebAssembly.Module is provided, this API returns just a WebAssembly.Instance, otherwise a ResultObject.
There was a problem hiding this comment.
not sure about this. but if you see this is reasonable we could do thus in separate pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.