Skip to content

(Re)move examples #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2020
Merged

(Re)move examples #1249

merged 1 commit into from
May 4, 2020

Conversation

dcodeIO
Copy link
Member

@dcodeIO dcodeIO commented May 4, 2020

From the recent discussions on the Wasm Discord I had the impression that our examples would benefit from an overhaul, and moved the ones we had, plus a few new ones, to their own repository. The new ones are "Interference effect" and "Loader" and I modernized the existing ones where necessary. Also started a Ray tracer example, but I'm not yet happy with its efficiency/interop story and will revisit later.

As such, this PR removes them from the main repo and leaves a README behind to forward to the new location.

@dcodeIO
Copy link
Member Author

dcodeIO commented May 4, 2020

@MaxGraey What's your opinion on moving n-body here? Will this complicate things unnecessarily, or will it be fine?

@MaxGraey
Copy link
Member

MaxGraey commented May 4, 2020

Hmm, I guess n-body also could more away to new place. Anyway we always could create syntactic tests for checking optimization quality

@dcodeIO
Copy link
Member Author

dcodeIO commented May 4, 2020

Alright, going to merge. If necessary, we can revisit. Perhaps, at some point, a benchmarks repository would be great as well.

@dcodeIO dcodeIO merged commit 6ebbedc into master May 4, 2020
@dcodeIO dcodeIO deleted the move-examples branch May 14, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants