Add bultins: i32/i64/f32/f64.eq/ne #2246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcodeIO
reviewed
Apr 9, 2022
Comment on lines
+139
to
+146
| // @ts-ignore: decorator | ||
| @builtin | ||
| export declare function eq<T>(left: T, right: T): i32; | ||
|
|
||
| // @ts-ignore: decorator | ||
| @builtin | ||
| export declare function ne<T>(left: T, right: T): i32; | ||
|
|
There was a problem hiding this comment.
This file seems to be missing the declarations for i32.eq etc., which probably didn't show up in tests since only the generic variants are used.
There was a problem hiding this comment.
I guess this also implies that adding the remaining tests would be good alongside :)
There was a problem hiding this comment.
I fixed them on another pull req.
#2258
dcodeIO
reviewed
Apr 9, 2022
dcodeIO
reviewed
Apr 9, 2022
Co-authored-by: dcode <dcode@dcode.io>
Co-authored-by: dcode <dcode@dcode.io>
Co-authored-by: dcode <dcode@dcode.io>
Co-authored-by: dcode <dcode@dcode.io>
…mblyscript into 1310-eq-ne-instructions
|
Sorry,the history was broken. I'll make another pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⯈add eq/ne to builtin.ts
Related issue: #1310