Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: diagnose when accessing setter only property #2800

Merged
merged 4 commits into from
Nov 21, 2023
Merged

fix: diagnose when accessing setter only property #2800

merged 4 commits into from
Nov 21, 2023

Conversation

HerrCai0907
Copy link
Member

@HerrCai0907 HerrCai0907 commented Nov 15, 2023 •
edited
Loading

This will introduce some incompatible with TS. since TS is support this but report undefined error in runtime.

CountBleck
CountBleck approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@CountBleck CountBleck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

src/resolver.ts Outdated Show resolved Hide resolved
@HerrCai0907 @CountBleck
Update src/resolver.ts
8443bdc 
Co-authored-by: CountBleck <Mr.YouKnowWhoIAm@protonmail.com>
@HerrCai0907 HerrCai0907 merged commit 153def6 into AssemblyScript:main Nov 21, 2023
13 checks passed
@HerrCai0907 HerrCai0907 deleted the fix/setter branch November 21, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CountBleck CountBleck CountBleck approved these changes

@dcodeIO dcodeIO Awaiting requested review from dcodeIO

@MaxGraey MaxGraey Awaiting requested review from MaxGraey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HerrCai0907 @CountBleck