Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clear garbage bits before cast short integer to float #2813

Merged
merged 2 commits into from
Jan 15, 2024
Merged

fix: clear garbage bits before cast short integer to float #2813

merged 2 commits into from
Jan 15, 2024

Conversation

HerrCai0907
Copy link
Member

Fixes #2812.

CountBleck
CountBleck approved these changes Jan 15, 2024
View reviewed changes
src/compiler.ts Outdated Show resolved Hide resolved
@HerrCai0907 @CountBleck
Update src/compiler.ts
37c5fb6 
Co-authored-by: CountBleck <Mr.YouKnowWhoIAm@protonmail.com>
@HerrCai0907 HerrCai0907 merged commit 67579de into AssemblyScript:main Jan 15, 2024
13 checks passed
@HerrCai0907 HerrCai0907 deleted the fix/2812 branch January 15, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CountBleck CountBleck CountBleck approved these changes

@dcodeIO dcodeIO Awaiting requested review from dcodeIO

@MaxGraey MaxGraey Awaiting requested review from MaxGraey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The results of arithmetic operations with u8 are not truncated to 8 bits, when assigned to f64
2 participants
@HerrCai0907 @CountBleck