Skip to content

Revisit old draft implementation of Array#splice #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 29, 2018
Merged

Revisit old draft implementation of Array#splice #347

merged 9 commits into from
Nov 29, 2018

Conversation

MaxGraey
Copy link
Member

@MaxGraey MaxGraey requested a review from dcodeIO November 27, 2018 12:48
@MaxGraey MaxGraey changed the title [WIP] Revisit old draft implementation of Array#splice Revisit old draft implementation of Array#splice Nov 27, 2018
@MaxGraey
Copy link
Member Author

Could you merge this if no more suggestions?

@dcodeIO dcodeIO merged commit 3c5c2ce into AssemblyScript:master Nov 29, 2018
@dcodeIO
Copy link
Member

dcodeIO commented Nov 29, 2018

Good point on .splice(0) (never used it that way, but seems legit). Thanks!

@MaxGraey MaxGraey deleted the improve-splice branch November 29, 2018 14:42
willemneal pushed a commit to willemneal/assemblyscript that referenced this pull request Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants