Skip to content

[Implement] Buffer#inspect #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

[Implement] Buffer#inspect #15

wants to merge 17 commits into from

Conversation

jtenner
Copy link
Contributor

@jtenner jtenner commented Jul 22, 2019

No description provided.

@jtenner jtenner requested a review from dcodeIO July 22, 2019 18:17
@jtenner jtenner self-assigned this Jul 22, 2019
@jtenner jtenner changed the title [Implement] Buffer#concat (todo: fix tlsf problem) [Implement] Buffer#inspect (todo: fix tlsf problem) Jul 22, 2019
@jtenner
Copy link
Contributor Author

jtenner commented Jul 23, 2019

@dcodeIO I think this could probably be optimized further but I've hit my limit. Any thoughts?

@jtenner jtenner changed the title [Implement] Buffer#inspect (todo: fix tlsf problem) [Implement] Buffer#inspect Jul 23, 2019
@jtenner jtenner added the enhancement New feature or request label Jul 23, 2019
@jtenner
Copy link
Contributor Author

jtenner commented Aug 1, 2019

This method is the reason why I created the charsFromByte() method. Now we can re-use it here in the .inspect() method.

All set for review @dcodeIO

MaxGraey
MaxGraey reviewed Aug 6, 2019
View reviewed changes
MaxGraey
MaxGraey reviewed Aug 6, 2019
View reviewed changes
@jtenner
Copy link
Contributor Author

jtenner commented Mar 13, 2020

Using the new __aspectReflectAs() api, we can log(new ArrayBuffer()) with the inspect output just like node.js outputs Buffers. Will have to revisit this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxGraey MaxGraey MaxGraey left review comments

@dcodeIO dcodeIO Awaiting requested review from dcodeIO

Assignees

@jtenner jtenner

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtenner @MaxGraey