Address PR comments

AstarNetwork · Jul 24, 2023 · c393846 · c393846
1 parent afb033c
commit c393846
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/bin/collator/src/rpc.rs b/bin/collator/src/rpc.rs
@@ -331,7 +331,7 @@ where
         )
         .into_rpc(),
     )?;
-    // TODO: remove this? This would mean we have two distinct tx pool implementations! What is the difference?
+
     io.merge(tx_pool.into_rpc())?;
 
     Ok(io)

diff --git a/chain-extensions/pallet-assets/src/lib.rs b/chain-extensions/pallet-assets/src/lib.rs
@@ -93,6 +93,7 @@ impl<T, W> Default for AssetsExtension<T, W> {
 impl<T, W> ChainExtension<T> for AssetsExtension<T, W>
 where
     T: pallet_assets::Config + pallet_contracts::Config,
+    <T as pallet_assets::Config>::AssetId: Copy,
     <<T as SysConfig>::Lookup as StaticLookup>::Source: From<<T as SysConfig>::AccountId>,
     <T as SysConfig>::AccountId: From<[u8; 32]>,
     W: weights::WeightInfo,
@@ -364,7 +365,7 @@ where
                 let base_weight = <W as weights::WeightInfo>::metadata_name();
                 env.charge_weight(base_weight)?;
 
-                let name = pallet_assets::Pallet::<T>::name(id.clone());
+                let name = pallet_assets::Pallet::<T>::name(id);
                 env.write(&name.encode(), false, None)?;
             }
             AssetsFunc::MetadataSymbol => {
@@ -373,7 +374,7 @@ where
                 let base_weight = <W as weights::WeightInfo>::metadata_symbol();
                 env.charge_weight(base_weight)?;
 
-                let symbol = pallet_assets::Pallet::<T>::symbol(id.clone());
+                let symbol = pallet_assets::Pallet::<T>::symbol(id);
                 env.write(&symbol.encode(), false, None)?;
             }
             AssetsFunc::MetadataDecimals => {
@@ -382,7 +383,7 @@ where
                 let base_weight = <W as weights::WeightInfo>::metadata_decimals();
                 env.charge_weight(base_weight)?;
 
-                let decimals = pallet_assets::Pallet::<T>::decimals(id.clone());
+                let decimals = pallet_assets::Pallet::<T>::decimals(id);
                 env.write(&decimals.encode(), false, None)?;
             }
             AssetsFunc::TransferOwnership => {

diff --git a/chain-extensions/xvm/src/lib.rs b/chain-extensions/xvm/src/lib.rs
@@ -82,7 +82,7 @@ where
                             target: "xvm-extension::xvm_call",
                             "root origin not supported"
                         );
-
+                        // TODO: expand XvmErrors with BadOrigin
                         return Ok(RetVal::Converging(XvmExecutionResult::UnknownError as u32));
                     }
                 };

diff --git a/runtime/local/src/lib.rs b/runtime/local/src/lib.rs
@@ -806,7 +806,7 @@ parameter_types! {
     pub const DepositPerItem: Balance = deposit(1, 0);
     pub const DepositPerByte: Balance = deposit(0, 1);
     // Fallback value if storage deposit limit not set by the user
-    pub const DefaultDepositLimit: Balance = deposit(1024, 1024 * 1024);
+    pub const DefaultDepositLimit: Balance = deposit(16, 16 * 1024);
     pub Schedule: pallet_contracts::Schedule<Runtime> = Default::default();
 }