Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy lints #1362

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Fix clippy lints #1362

merged 1 commit into from
Sep 13, 2024

Conversation

vedhavyas
Copy link
Contributor

Pull Request Summary
A small change set to fix the clippy lints.
There is one more warning

warning: lint `clippy::clone_double_ref` has been renamed to `suspicious_double_ref_op`
  |
  = help: use the new name `suspicious_double_ref_op`
  = note: requested on the command line with `-A clippy::clone_double_ref`
  = note: `#[warn(renamed_and_removed_lints)]` on by default

Mostly coming from upstream I think since I couldn't find it in our repo.

Check list

  • added or updated unit tests
  • updated Astar official documentation
  • added OnRuntimeUpgrade hook for precompile revert code registration
  • added benchmarks & weights for any modified runtime logics.

Copy link
Contributor

@ipapandinas ipapandinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vedhavyas vedhavyas merged commit 393b50b into master Sep 13, 2024
6 of 8 checks passed
@vedhavyas vedhavyas deleted the fix_lints branch September 13, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants