Fix RTD Poetry configuration #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev_master #379 +/- ##
===========================================
Coverage 74.21% 74.21%
===========================================
Files 56 56
Lines 7854 7854
===========================================
Hits 5829 5829
Misses 2025 2025 ☔ View full report in Codecov by Sentry. |
This follows a change in RTD's user guide found at https://docs.readthedocs.io/en/stable/build-customization.html#install-dependencies-with-poetry, which they changed in readthedocs/readthedocs.org#11152 following a breaking change introduced by Poetry 1.8.
teutoburg
force-pushed
the
378-fix-rtd
branch
from
8e56a80
to
297e07e
Compare
teutoburg
changed the title
|
RTD works again, so I'm merging this... |
This was referenced Feb 28, 2024
|
Thanks. Sounds like the problem would probably also fix itself when RTD will start setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows a change in RTD's user guide found at https://docs.readthedocs.io/en/stable/build-customization.html#install-dependencies-with-poetry, which they changed in readthedocs/readthedocs.org#11152 following a breaking change introduced by Poetry 1.8.
If this works, we should roll this change out to all our packages using Poetry to build doc, as the same error also occurs elsewhere (see e.g. https://readthedocs.org/projects/skycalc-ipy/builds/23587453/)