Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GNOME 46] History Graph in drop down not showing #40

Closed
3dsf opened this issue Jan 26, 2024 · 7 comments
Closed

[GNOME 46] History Graph in drop down not showing #40

3dsf opened this issue Jan 26, 2024 · 7 comments
Labels
bug Something isn't working fixed

Comments

@3dsf
Copy link

3dsf commented Jan 26, 2024

Description

The drop down does not show a history graph even though there is activity

Steps to Reproduce

  1. Unknown

Screenshots

Screenshot from 2024-01-25 19-53-41

Environment

  • Astra Monitor Version: pre-v8
  • GNOME Version: 46
  • Operating System and Version: Fedora Rawhide (6.8)
  • Other Relevant System Information:

Logs

Additional Context

Checked, persists with a reboot
Also, you ko-fi page is not fully enabled

@3dsf 3dsf added the bug Something isn't working label Jan 26, 2024
@ljuzig
Copy link
Collaborator

ljuzig commented Jan 26, 2024

Thanks for the submission. I think I'll wait a bit to see this kind of bug. GNOME 46 is in alpha release, and according to the EGO team, a lot of features are prone to bugs and changes in the coming weeks. To better figure out what's on my end and what's on GNOME's, I'll wait for the feature freeze with the beta release, which I believe is on February 10th. For now, I'll keep this issue open, but I'll take another look if the problem persists after the February 10th beta.

As you can see from this screen a lot of things do look very different in Gnome 46 right now, not just the graph:
image

@ljuzig
Copy link
Collaborator

ljuzig commented Jan 26, 2024

Also try to update to the version on EGO which have a lot of fixes over your version.
Oh and many thanks for the ko-fi page. I fixed it!

@ljuzig ljuzig changed the title History Graph in drop down not showing [GNOME 46] History Graph in drop down not showing Jan 26, 2024
@3dsf
Copy link
Author

3dsf commented Jan 26, 2024

I ran journalctl -b -e for something unrelated and saw a bunch of entries like this

Jan 26 11:30:24 fedora gnome-shell[2723]: JS ERROR: TypeError: (intermediate value).cairo_set_source_color is not a function
                                          repaint@file:///home/3dsf/.local/share/gnome-shell/extensions/monitor@astraext.github.io/src/processor/processorGraph.js:78:17
                                          GraphBase/<@file:///home/3dsf/.local/share/gnome-shell/extensions/monitor@astraext.github.io/src/graph.js:62:57
                                          setUsageHistory@file:///home/3dsf/.local/share/gnome-shell/extensions/monitor@astraext.github.io/src/graph.js:162:27
                                          buildGraph/<@file:///home/3dsf/.local/share/gnome-shell/extensions/monitor@astraext.github.io/src/processor/processorHeader.js:242:24
                                          notify@file:///home/3dsf/.local/share/gnome-shell/extensions/monitor@astraext.github.io/src/monitor.js:175:26
                                          @resource:///org/gnome/shell/ui/init.js:21:20

@ljuzig
Copy link
Collaborator

ljuzig commented Jan 26, 2024

@3dsf This is related and the very likely the root cause of the missing graphs. It's been deprecated for a while so probably they just removed it. I will fix that soon and give you a build to test if it fixes the graphs.

EDIT:
The problem might be a bit more complex to solve. We depends on Clutter which is kind of deprecated. We need to replace it which will require some time.

EDIT2: That explains also the inconsistencies with other UI stuff.

ljuzig added a commit that referenced this issue Jan 27, 2024
@ljuzig
Copy link
Collaborator

ljuzig commented Jan 27, 2024

@3dsf try this version, the graphs rendering should be fixed now:
EDIT: package removed, see comment below

As for the layout bugs, I need more time to fix that. I have to completely replace an important component used almost everywhere.

@ljuzig ljuzig closed this as completed in 01379d8 Jan 27, 2024
@ljuzig
Copy link
Collaborator

ljuzig commented Jan 27, 2024

I actually fixed the layout problems without replacing Clutter. We keep it for now since there's no proper replacement of Clutter.GridLayout on St.

Everything's fixed now.
Please manually install and try this one:
monitor@astraext.github.io.shell-extension.zip

Thank you!

@ljuzig ljuzig added the fixed label Jan 27, 2024
@3dsf
Copy link
Author

3dsf commented Jan 27, 2024

Looks good to me : ) Thanks!
Screenshot from 2024-01-27 11-42-49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed
Projects
None yet
Development

No branches or pull requests

2 participants