Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2d #505

Merged
merged 11 commits into from
Nov 29, 2024
Merged

Feature/2d #505

merged 11 commits into from
Nov 29, 2024

Conversation

ghiander
Copy link
Collaborator

2D version of Jazzy. No 3D embeddings enable faster featurisation with a bit less accuracy but no failures due to RDKit embedding failure

@ghiander ghiander requested a review from f3rmion November 26, 2024 18:10
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (44400db) to head (5700a61).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #505   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          602       619   +17     
  Branches        97       100    +3     
=========================================
+ Hits           602       619   +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@f3rmion f3rmion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghiander ghiander merged commit 81385af into master Nov 29, 2024
22 checks passed
@ghiander ghiander deleted the feature/2d branch November 29, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants