Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add section to adjust cmp label and menu length #165

Merged
merged 5 commits into from
Oct 17, 2024
Merged

docs: add section to adjust cmp label and menu length #165

merged 5 commits into from
Oct 17, 2024

Conversation

azdanov
Copy link
Contributor

@azdanov azdanov commented Oct 17, 2024

📑 Description

This adds a section on how to adjust cmp to limit it's size. To solve an issue like this: hrsh7th/nvim-cmp#1154 (comment)

ℹ Additional Information

@netlify Netlify
Copy link

netlify bot commented Oct 17, 2024 •
edited
Loading

✅ Deploy Preview for peaceful-platypus-6db452 ready!

Name Link
🔨 Latest commit 69ff3ff
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-platypus-6db452/deploys/671117deb3bf2f0007ad4485
😎 Deploy Preview https://deploy-preview-165--peaceful-platypus-6db452.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 95 (🔴 down 2 from production)
Accessibility: 98 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: 90 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

mehalter
mehalter requested changes Oct 17, 2024
View reviewed changes
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! One small comment :)

@azdanov @mehalter
chore: modify menu item only if it exists
07886a9 
Co-authored-by: Micah Halter <micah@mehalter.com>
@azdanov
Copy link
Contributor Author

azdanov commented Oct 17, 2024

Thanks for suggestion, I didn't realize that 🙂

mehalter
mehalter requested changes Oct 17, 2024
View reviewed changes
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! One last thing I noticed that needs to get fixed and then a refactor recommendation that I don't mind being ignored if you prefer the code as it is now

src/content/docs/recipes/cmp.mdx Outdated Show resolved Hide resolved
src/content/docs/recipes/cmp.mdx Show resolved Hide resolved
azdanov and others added 2 commits October 17, 2024 16:53
@azdanov
chore: close code block
092b571
@azdanov @mehalter
refactor: extract truncate logic
9463ab8 
Co-authored-by: Micah Halter <micah@mehalter.com>
mehalter
mehalter approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! :shipit:

@mehalter mehalter merged commit f978f0e into AstroNvim:main Oct 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehalter mehalter mehalter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azdanov @mehalter