Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no deep import of dependencies from graphql #82

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonnedeprez
Copy link

The deep import of getArgumentValues from the graphql package causes trouble when using this library in an esm/esbuild based project, because esbuild pulls in the complete package a second time. The graphql package will detect this at runtime and will throw an error.

The deep import of getArgumentValues from the graphql package causes trouble when using this library in an esm/esbuild based project. Esbuild pulls in the complete package a second time.
@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2022

⚠️ No Changeset found

Latest commit: 584c8df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@XBeg9 XBeg9 self-requested a review November 23, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant