CookieStore slows down with increasing number of cookies

[joshovi]

In

async-http-client/client/src/main/java/org/asynchttpclient/cookie/ThreadSafeCookieStore.java

Line 160 in 365c1e6

List<Cookie> result = cookieJar.entrySet().stream().filter(pair -> {

the look up over cookies traverses all entries in the map. The side effect to clean all expired cookies traverses the list again. The cost for algorithm scales with the number of cookies.

In our project we had to disable the cookie store, i.e.
new DefaultAsyncHttpClientConfig.Builder() .setCookieStore(null) ... .build()

Maybe you could rewrite the function using another data structure that facilitates the look up for candidate cookies and then make a lazy removal of the expired candidates, or remove expired cookies asynchronously and periodically.

[slandelle]

Contributions welcome

[sivaalli]

@slandelle Can I work on a fix for this?

[slandelle]

@sivaalli sure, contributions welcome