Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epoll/Kqueue optional #1717

Closed
swimmesberger opened this issue Apr 23, 2020 · 3 comments · Fixed by #1718
Closed

Epoll/Kqueue optional #1717

swimmesberger opened this issue Apr 23, 2020 · 3 comments · Fixed by #1718
Milestone

Comments

@swimmesberger
Copy link
Contributor

swimmesberger commented Apr 23, 2020

When using async-http-client in an OSGi environment and we do not want to use the native transport we have to ship with the io.netty:netty-transport-native-epoll, io.netty:netty-transport-native-kqueue and io.netty:netty-transport-native-unix-common dependencies even though they are not necessary.

We would prefer to use async-http-client with the default transport without the native dependencies. One way to fix this would be to markt these dependencies (and packages) in the maven-bundle-plugin as optional imports. (https://github.com/AsyncHttpClient/async-http-client/blob/master/pom.xml#L194)
Currently every dependency is imported as required the '*' symbol. It's possible to mark some of these packages as optional with following instructions:
io.netty.channel.kqueue;resolution:=optional,io.netty.channel.epoll;resolution:=optional

@slandelle
Copy link
Contributor

Contributions welcome

@swimmesberger
Copy link
Contributor Author

Made PR #1718

@slandelle
Copy link
Contributor

Thx

@slandelle slandelle added this to the 2.12.2 milestone Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants