Implemented cookie jar and its use in http redirection #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Existing implementation doesn't have proper support of cookie jar. It causes problem when requesting http URL that redirects to another location. Modifications: Implemented configurable CookieStore and default thread-safe implementation of it. Also modified redirection interceptor to use it. Result: Cookie store will be used for all http requests.
|
Thanks a lot! |
|
@slandelle My pleasure! Let me know if you need help with another feature or something. |
|
I've just merged another PR that introduces SOCKS proxies support.
Help is always welcome :) Doc, pending issues/features, whatever... |
|
This PR use the content of CookieStore to override the header("Cookie"). Instead of doing override, can we MEGER CookieStore to existing header("Cookie") if it exists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Existing implementation doesn't have proper support of cookie jar. It causes problem when requesting http URL that redirects to another location.
Modifications:
Implemented configurable CookieStore and default thread-safe implementation of it. Also modified redirection interceptor to use it.
Result:
Cookie store will be used for all http requests.