Added BlockingConnectionSemaphoreFactory #1586
Merged
+463
−228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #1527 here's a simple implementation of a blocking
ConnectionSemaphoreFactory
using plain old Java semaphores.In some cases where a limit on the number of connections is needed, it's preferable to wait for a free channel over throwing an exception. In such cases this factory can be set in the configuration.
I also think it might be a good idea to add a simpler blocking/non-blocking boolean flag in the configuration for this behavior. It would be simpler for users to find as opposed to
setConnectionSemaphoreFactory(new BlockingConnectionSemaphoreFactory()))
.