Expose SSL Session of a connection to AsyncHandler.onTlsHandshakeSuccess #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slandelle any comments on this PR? Thanks. |
|
Looks fine but will have to release a minor version as it's a minor breaking change. |
|
@slandelle would you like me to set the version in this PR? If so, should I go with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this change is to expose underlying SSLSession object once handshake is successful. This seems like a feature that can be useful to anyone that needs to retrieve session and/or certificate information from the connection.
A quick search for the feature yielded this conversation in google groups from 2014 so it seems people have been trying to do this for a while:
https://groups.google.com/forum/#!msg/asynchttpclient/7ySVbKqntgc/_pycVfrwiVMJ