Skip to content

Retrofit improvements #1615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2019
Merged

Retrofit improvements #1615

merged 2 commits into from
Feb 26, 2019

Conversation

bfg
Copy link
Contributor

@bfg bfg commented Feb 25, 2019

  • bugfix: don't try to cancel already completed future, manifesting in bogus warning messages
  • improvement: added ability to fetch http client instance from a supplier.

bfg added 2 commits February 25, 2019 00:19
@bfg
Don't try to cancel already completed future.
805f246 
If AHC is used concurrently with rxjava retrofit call adapter using
`flatMap(Function, maxConcurrency)` warning messages are being logged
about future not being able to be cancelled, because it's already
complete. This patch remedies situation by first checking whether future
has been already completed.
@bfg
Added ability to fetch async http client instance from a supplier.
c72bf1c 
Sometimes it's handy not to tie call factory to particular http client
instance, but to fetch it from a supplier. This patch adds ability to
fetch http client from a supplier while retaining ability to use
particular, fixed http client instance.
@slandelle
Copy link
Contributor

Thanks!
Next time, could you please send 2 different PRs? :)

@slandelle slandelle closed this Feb 26, 2019
@slandelle slandelle reopened this Feb 26, 2019
@slandelle slandelle merged commit 1e3ed1d into AsyncHttpClient:master Feb 26, 2019
@bfg
Copy link
Contributor Author

bfg commented Feb 26, 2019

Will do; i was wondering whether i should open two PRs, but decided to go with two commits, because first one is so small. Thanks for accepting PR!

@bfg bfg deleted the retrofit_improvements branch February 26, 2019 16:46
@bfg bfg restored the retrofit_improvements branch February 26, 2019 16:48
@bfg
Copy link
Contributor Author

bfg commented Feb 27, 2019

Hey, i've noticed that you've tagged 2.8.0 release with this PR included and i was really positively surprised by this. Thanks! However i don't see release on maven-central, nor 2.8.x snapshots in snapshot repo, is there a possibility that some publish task failed to complete successfully?

@slandelle
Copy link
Contributor

@bfg Deployments and indexation on maven central are asynchronous and there's typically a 20 min delay before the binary is actually deployed and several hours before it's indexed and visible on search.maven.org.

The binaries are already deployed: https://repo1.maven.org/maven2/org/asynchttpclient/async-http-client-project/2.8.0/

@bfg
Copy link
Contributor Author

bfg commented Feb 27, 2019

@slandelle thanks for clarification!

@bfg bfg deleted the retrofit_improvements branch February 27, 2019 12:10
@bfg bfg mentioned this pull request Feb 27, 2019
Closed
@slandelle slandelle added this to the 2.8.0 milestone May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@bfg @slandelle