Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated maven-javadoc-plugin to 3.0.1 #1621

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

bfg
Copy link
Contributor

@bfg bfg commented Feb 28, 2019

Before this patch build was using outdated javadoc plugin which failed
build on OracleJDK 8 due to javadoc generation error on
extras/retrofit2 module. Builds on OpenJDK 8 finished successfully.

Changes:

  • maven-javadoc-plugin version bump to 3.0.1
  • added javadoc generation to travis build recipe

Before this patch build was using outdated javadoc plugin which failed
build on OracleJDK 8 due to javadoc generation error on
`extras/retrofit2` module. Builds on OpenJDK 8 finished successfully.

Changes:

* maven-javadoc-plugin version bump to `3.0.1`
* added javadoc generation to travis build recipe
@bfg
Copy link
Contributor Author

bfg commented Feb 28, 2019

OpenJDK 8:

~/dev/async-http-client (retrofit2_javadoc_issue)$ mvn --version
Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T20:41:47+02:00)
Maven home: /home/bfg/software/maven
Java version: 1.8.0_191, vendor: Oracle Corporation, runtime: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.18.0-15-generic", arch: "amd64", family: "unix"

~/dev/async-http-client (retrofit2_javadoc_issue)$ mvn clean package javadoc:javadoc -DskipTests=true
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  22.862 s
[INFO] Finished at: 2019-02-28T18:30:31+01:00
[INFO] ------------------------------------------------------------------------

Oracle JDK 8

~/dev/async-http-client (retrofit2_javadoc_issue)$ JAVA_HOME=/opt/java/jdk1.8.0_201 mvn --version
Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T20:41:47+02:00)
Maven home: /home/bfg/software/maven
Java version: 1.8.0_201, vendor: Oracle Corporation, runtime: /opt/java/jdk1.8.0_201/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.18.0-15-generic", arch: "amd64", family: "unix"

~/dev/async-http-client (retrofit2_javadoc_issue)$ JAVA_HOME=/opt/java/jdk1.8.0_201 mvn clean package javadoc:javadoc -DskipTests=true
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  22.744 s
[INFO] Finished at: 2019-02-28T18:31:57+01:00
[INFO] ------------------------------------------------------------------------

@slandelle slandelle merged commit cf2348e into AsyncHttpClient:master Feb 28, 2019
@slandelle
Copy link
Contributor

@bfg AHC 2.8.1 is released. Thanks!

@bfg bfg deleted the retrofit2_javadoc_issue branch February 28, 2019 22:49
@slandelle slandelle added this to the 2.8.1 milestone May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants