Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1632: Stop doing reverse DNS lookups #1633

Merged
merged 1 commit into from
May 17, 2019

Conversation

n-miles
Copy link
Contributor

@n-miles n-miles commented May 15, 2019

See #1632

@n-miles
Copy link
Contributor Author

n-miles commented May 16, 2019

@slandelle My build failed due to ChunkingTest.testBufferLargerThanFileWithStreamBodyGenerator(). The test passes locally and I am relatively sure I didn't do anything that would affect this test. Is there a way to re-run a build?

java.util.concurrent.ExecutionException: java.util.concurrent.TimeoutException: Request timeout to localhost:37135 after 1000 ms
	at org.asynchttpclient.request.body.ChunkingTest.waitForAndAssertResponse(ChunkingTest.java:106)
	at org.asynchttpclient.request.body.ChunkingTest.doTestWithInputStreamBodyGenerator(ChunkingTest.java:61)
	at org.asynchttpclient.request.body.ChunkingTest.testBufferLargerThanFileWithStreamBodyGenerator(ChunkingTest.java:39)
Caused by: java.util.concurrent.TimeoutException: Request timeout to localhost:37135 after 1000 ms

@n-miles
Copy link
Contributor Author

n-miles commented May 16, 2019

Looks like you lost a build to the same test 3 months ago

@n-miles
Copy link
Contributor Author

n-miles commented May 16, 2019

I did

git commit --amend --no-edit
git push myfork issue-1632 -f

which re-ran the build and it passed this time

@slandelle slandelle merged commit 4803ab4 into AsyncHttpClient:master May 17, 2019
@slandelle
Copy link
Contributor

Thanks!

@n-miles n-miles deleted the issue-1632 branch May 23, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants