Add unit tests for org.asynchttpclient.netty.util.ByteBufUtils #1639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slandelle
requested changes
Jun 11, 2019
Contributor
slandelle
left a comment
slandelle
left a comment
There was a problem hiding this comment.
Thanks for contributing. Could you please address comments?
netty-utils/src/test/java/org/asynchttpclient/netty/util/ByteBufUtilsTests.java
Show resolved
Hide resolved
netty-utils/src/test/java/org/asynchttpclient/netty/util/ByteBufUtilsTests.java
Outdated
Show resolved
Hide resolved
netty-utils/src/test/java/org/asynchttpclient/netty/util/ByteBufUtilsTests.java
Outdated
Show resolved
Hide resolved
| ByteBuf byteBuf2 = Unpooled.copiedBuffer(new byte[]{'o'}); | ||
|
|
||
| ArrayAsserts.assertArrayEquals(new char[]{}, ByteBufUtils | ||
| .byteBuf2Chars(Charset.forName("ISO-8859-1"), byteBuf1)); |
Contributor
There was a problem hiding this comment.
Why use ISO-8859-1 and not US-ASCII?
Contributor
Author
There was a problem hiding this comment.
As I was trying to cover the branch decodeChars(buf, charset) in the byteBuf2Chars(Charset charset, ByteBuf buf) method.
netty-utils/src/test/java/org/asynchttpclient/netty/util/ByteBufUtilsTests.java
Outdated
Show resolved
Hide resolved
EricHetti
force-pushed
the
add-diffblue-tests
branch
from
fe3e2e0 to
8b10510
Compare
slandelle
requested changes
Jun 11, 2019
Contributor
slandelle
left a comment
slandelle
left a comment
There was a problem hiding this comment.
Please address last comment and we'll be good to go. Thanks!
netty-utils/src/test/java/org/asynchttpclient/netty/util/ByteBufUtilsTests.java
Outdated
Show resolved
Hide resolved
These tests were written using Diffblue Cover.
EricHetti
force-pushed
the
add-diffblue-tests
branch
from
8b10510 to
5824732
Compare
Contributor
Author
|
Hi @slandelle just following up and wondering if you would like me to make any changes to the PR? |
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've analysed your codebase and noticed that
org.asynchttpclient.netty.util.ByteBufUtilsis not fully tested.I've written some tests for the methods in this class with the help of Diffblue Cover.
Hopefully, these tests will help you detect any regressions caused by future code changes. If you would find it useful to have additional tests written for this repository, I would be more than happy to look at other classes that you consider important.