Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1686 configure accuracy in HashedTimerWheel #1705

Merged
merged 3 commits into from
Mar 24, 2020
Merged

#1686 configure accuracy in HashedTimerWheel #1705

merged 3 commits into from
Mar 24, 2020

Conversation

zagorulkinde
Copy link
Contributor

@zagorulkinde zagorulkinde commented Mar 12, 2020 •
edited
Loading

Fix issue #1686

@slandelle
Copy link
Contributor

Could you please elaborate on the benefits of this PR? In particular how the defaults are not suited for you.

@zagorulkinde
Copy link
Contributor Author

Hi. In this PR i'd resolved the issue #1686 to decrease delay between RequestTimeout and ListenableFuture's completion. I want to get responses as fast as possible. Also i want to mention that default values now the same as it was before this PR.

@zagorulkinde
Copy link
Contributor Author

Hello @slandelle what do you think?

@slandelle
Copy link
Contributor

Why not. Could you please make it more simple and remove the TimeUnit and pass the duration as a number of millis?

@zagorulkinde
Copy link
Contributor Author

removed TimeUnit and passed duration as number of millis;

@zagorulkinde zagorulkinde reopened this Mar 18, 2020
@zagorulkinde
Copy link
Contributor Author

Why not. Could you please make it more simple and remove the TimeUnit and pass the duration as a number of millis?

Hey. Any feedback?

slandelle
slandelle requested changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@slandelle slandelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit and good to go! Sorry for the delay.

@zagorulkinde zagorulkinde changed the title #1686 added ability to configure accuracy in HashedTimerWheel #1686 configure accuracy in HashedTimerWheel Mar 24, 2020
@slandelle slandelle merged commit 7a69311 into AsyncHttpClient:master Mar 24, 2020
@slandelle
Copy link
Contributor

Thanks!

@slandelle slandelle added this to the 2.12.0 milestone Mar 24, 2020
@mpantelimon mpantelimon mentioned this pull request Oct 25, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slandelle slandelle slandelle requested changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@zagorulkinde @slandelle