Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to jakarta.activation 1.2.2 #1715

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Upgrade to jakarta.activation 1.2.2 #1715

merged 1 commit into from
Apr 15, 2020

Conversation

amarkevich
Copy link
Contributor

No description provided.

@slandelle
Copy link
Contributor

slandelle commented Apr 15, 2020 •
edited
Loading

This suggested change is broken. We use the activation framework because we need the MimetypesFileTypeMap class and its associated mimetypes.default file (see #1541).

In com.sun.activation:javax.activation jar, mimetypes.default is shipped as expected in /META-INF.
This file is missing from jakarta.activation:jakarta.activation-api.

@amarkevich
Copy link
Contributor Author

@slandelle switched to 'com.sun.activation:jakarta.activation:jar:1.2.2'

@slandelle slandelle merged commit ac2d4bd into AsyncHttpClient:master Apr 15, 2020
@slandelle
Copy link
Contributor

Thanks

@amarkevich amarkevich deleted the jakarta.activation branch April 15, 2020 13:10
@pierre pierre mentioned this pull request Jan 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amarkevich @slandelle