Propagate original request user-agent in proxy CONNECT requests #1742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 7, 2020 22:24
…hen a proxy is in the way, ensuring all outgoing requests bear the correct user agent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #1730, it appears that when using a proxy server and a custom user-agent header, the user-agent of the CONNECT request to the proxy server is not correctly set to be the custom one, but instead the default one.
This makes sure the user-agent header is propagated down to the CONNECT request as well, and changes the BasicHTTPToHTTPSTest to account for this as well (since they're logically similar - they both test for the existence of specific headers in the flow).
BTW: Propagate? Percolate? Bubble down? Simmer through? Feel free to change the phrasing.