Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #1752

Merged
merged 2 commits into from
Dec 13, 2020
Merged

Fix typos #1752

merged 2 commits into from
Dec 13, 2020

Conversation

LorenzNickel
Copy link
Contributor

Let me know I did a mistake and some of these are actually intended and I'll be happy to undo such changes

@TomGranot
Copy link
Contributor

TomGranot commented Dec 11, 2020 •
edited
Loading

Hey @LorenzNickel - thank you very much for this PR! The fact that people take the time to fix things that are cosmetic is highly appreciated.

We've got a problem with one of the tests (testMaxTotalConnections) that's re-occuring on both GitHub Actions and on Travis-CI . Both of them seem to be due to DNS errors, which are (supposedly) due to the agents running these tests, but I have not yet been able to verify that.

I hope to look into it later tonight and tomorrow and clear some of this up.

If I miss doing so please ping me, and have a great weekend!

Edit: Working on this in #1753.

@TomGranot TomGranot mentioned this pull request Dec 12, 2020
Merged
@TomGranot
Copy link
Contributor

TomGranot commented Dec 12, 2020 •
edited
Loading

@LorenzNickel Alright, finished and merged that test PR.

For now please sync your branch with master and it should then pass all tests. I will review the actual changes tomorrow, but if it's all cosmetics I don't see a reason not to approve once all lights are green.

@TomGranot @LorenzNickel
Fix Failing Github Actions Tests (#1753)
a7216fc 
* Bump GitHub Actions runner version to Ubuntu 20.04

* AsyncStreamHandlerTest.asyncOptionsTest - Allow for the appearance of the TRACE method in the server's response

* MaxTotalConnectionTest.testMaxTotalConnections - https://github.com --> https://www.youtube.com, https://google.com --> https://www.google.com 

* TextMessageTest.onFailureTest - Refactor logic for more granular testing (accept ConnectException in addition to UnknownHostException, but check for "DNS Name not found" in exception cause)
@TomGranot TomGranot merged commit 2b12d0b into AsyncHttpClient:master Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomGranot TomGranot TomGranot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LorenzNickel @TomGranot