chore: upgrade dependencies #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent the yak shave of upgrading the BFF to a ESM, this patch upgrades node-fetch to 2.7.0, which is currently the last version before it becomes a ESM only module. More info on upgrading further here: https://github.com/node-fetch/node-fetch/blob/main/docs/v3-UPGRADE-GUIDE.md#converted-to-es-module The same problem also caps our p-throttle version at 4.1.1: https://github.com/sindresorhus/p-throttle/releases/tag/v5.0.0
Seems like this was implicitly included by other packages, and not declared as an actual dependency.
This is due to a requirement in p-limit
rosvik
force-pushed
the
rosvik/update-dependencies
branch
from
cbdd025 to
bbf4cb7
Compare
rosvik
requested review from
gorandalum,
jorelosorio,
marius-at-atb and
KristianSelnas
as code owners
jorelosorio
approved these changes
Feb 9, 2024
Good point!
|
gorandalum
approved these changes
Feb 12, 2024
|
Waiting for 1.47 release before I merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/AtB-AS/kundevendt/issues/16263
My todolist, with descriptions, if anyone is interested
BFF dependencies (dev)
BFF dependencies (non-dev)
ts-nodeupgrade