Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil pointer dereference #25

Merged

Conversation

mlajkim
Copy link
Contributor

@mlajkim mlajkim commented Jul 5, 2023

Description

We encountered a bug while attempting to recover from a panic in the Athenz webhook: a runtime error occurred due to an invalid memory address or nil pointer dereference.

Also added temporary unit test just in case.

Type of change

  • Bug fix
  • New feature
  • Refactoring (no functional changes, no api changes)
  • Non-code changes (update documentation, pipeline, etc.)

Flags

  • Breaks backward compatibility
  • Requires a documentation update
  • Has untestable code

Related issue/PR


Checklist

  • Followed the guidelines in the CONTRIBUTING document
  • Added prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip] in the PR title if necessary
  • Tested and linted the code
  • Commented the code
  • Made corresponding changes to the documentation
  • Passed all pipeline checking

Checklist for maintainer

  • Use Squash and merge
  • Double-confirm the merge message has prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip]
  • Delete the branch after merge

@mlajkim mlajkim added the bug Something isn't working label Jul 5, 2023
@WindzCUHK WindzCUHK merged commit 1121f6f into master Jul 5, 2023
@WindzCUHK WindzCUHK deleted the fix-invalid-memory-address-or-nil-pointer-dereference branch July 5, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants